OCMock: Fix crash when running on iOS 15 device. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`object_getClass` crashes on some arguments when being run on an iOS 15 device. `object_getClass` is needed because OCMock needs to detect if the argument is actually a `OCMPassByRefSetter`, which disguises as a pointer to an object (`id *`) but is actually an object (`id`). The solution is to make sure before calling `object_getClass` that the type encoding of the argument is actually a pointer to an object, and then it should be safe to call `object_getClass`. The problem is that the value was previously wrapped with an `NSValue`, which disguised the type encoding as a `void *`. Therefore the check of whether the argument is `id *` is done before it will be wrapped with `NSValue`.
byohay
changed the title
|
Replaced with a more robust solution: erikdoe#503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object_getClasscrashes on some arguments when being run on an iOS 15device.
object_getClassis needed because OCMock needs to detect ifthe argument is actually a
OCMPassByRefSetter, which disguises as apointer to an object (
id *) but is actually an object (id).The solution is to make sure before calling
object_getClassthat thetype encoding of the argument is actually a pointer to an object, and
then it should be safe to call
object_getClass.The problem is that the value was previously wrapped with an
NSValue,which disguised the type encoding as a
void *. Therefore the check ofwhether the argument is
id *is done before it will be wrapped withNSValue.