-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use composer and change directory structure. #12
base: master
Are you sure you want to change the base?
Conversation
…accessible. This makes for an easier to secure system (since all php files are no longer in a subdir of the webroot)
@nhuhtlb @nhungpham can you quickly review this, if ok then we can merge. |
Its not done yet wip --> work in progress
|
oops sorry, I misread it. OK, @nhuhtlb @nhungpham @HoDucTien37 please wait until Sam comments this as done. |
Okay, I have updated it to work properly. After you merge, you MUST change the composer.json --> change it so it lists you guys as the author and change the package name, I chose Side note, I also removed |
@HoDucTien37 @nhuhtlb please follow up with what Sam has done and merge. Thanks! |
[WIP] Work In Progress, not yet ready for merge!
This PR aims to do 2 things:
New proposed directory structure:
-- public (containing entry PHP scripts, all js / image assets that do not need to be protected).
-- protected (containing project code)
-- protected/vendor (containing all dependencies
This allows anyone to simply set the webroot to public and it will work properly and securely.