Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composer and change directory structure. #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use composer and change directory structure. #12

wants to merge 5 commits into from

Conversation

SamMousa
Copy link

[WIP] Work In Progress, not yet ready for merge!

This PR aims to do 2 things:

  1. Remove dependencies from the repository and use composer instead.
  2. Change the directory structure so it is easier to secure.

New proposed directory structure:

  • root (containing LICENSE, README and composer.json)
    -- public (containing entry PHP scripts, all js / image assets that do not need to be protected).
    -- protected (containing project code)
    -- protected/vendor (containing all dependencies

This allows anyone to simply set the webroot to public and it will work properly and securely.

…accessible. This makes for an easier to secure system (since all php files are no longer in a subdir of the webroot)
@josephpnc
Copy link
Contributor

@nhuhtlb @nhungpham can you quickly review this, if ok then we can merge.

@SamMousa
Copy link
Author

SamMousa commented Apr 6, 2016

Its not done yet wip --> work in progress
On Apr 6, 2016 7:08 AM, "Joseph Pham Ngoc Cuong" notifications@github.com
wrote:

@nhuhtlb https://github.com/nhuhtlb @nhungpham
https://github.com/nhungpham can you quickly review this, if ok then we
can merge.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12 (comment)

@josephpnc
Copy link
Contributor

oops sorry, I misread it. OK, @nhuhtlb @nhungpham @HoDucTien37 please wait until Sam comments this as done.

@SamMousa
Copy link
Author

Okay, I have updated it to work properly.

After you merge, you MUST change the composer.json --> change it so it lists you guys as the author and change the package name, I chose sam-it/linxbooks you should probably go for something like linxhq/linxbooks.

Side note, I also removed @session_start() directive from config since it causes issues with Yii database session table creation.

@SamMousa SamMousa changed the title [WIP] Use composer and change directory structure. Use composer and change directory structure. Apr 13, 2016
@josephpnc
Copy link
Contributor

@HoDucTien37 @nhuhtlb please follow up with what Sam has done and merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants