Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust sc2 results table custom #2514

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Adjust sc2 results table custom #2514

merged 2 commits into from
Feb 7, 2023

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Feb 5, 2023 •
edited
Loading

Summary

  • kick legacy lastvs since PPTs store into the new field (purge run done)
  • rename main function from run to results to match commons
  • correctly use frame over args in awards table

How did you test this change?

Live, module not yet in use

@hjpalpha hjpalpha requested a review from Rathoz February 5, 2023 08:40
This was referenced Feb 6, 2023
Merged
Open
Rathoz
Rathoz approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rathoz Rathoz merged commit 951f501 into main Feb 7, 2023
@Rathoz Rathoz deleted the hjpalpha-patch-2 branch February 7, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rathoz Rathoz Rathoz approved these changes

Assignees
No one assigned
Labels
c: results_table chore g: starcraft Starcraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjpalpha @Rathoz