Allow new stream key format as input in matches #3111

hjpalpha · 2023-07-10T07:31:54Z

Summary

Currently matches do not accept stream keys in the form of twitch_en_1.

Additionally in Module:Countdown the lines 36-49 are redundant, they do nothing except increase runtime (it processes new keys but pushes them with the same key again into the args table so factually no change accomplished).

And on discord there was the question about allowing >1 stream per platform in match countdowns.

~~Additional changes that i would push after this PR got merged:~~

https://liquipedia.net/commons/index.php?title=Module%3ACountdown%2Fdev&type=revision&diff=503976&oldid=503648 (lines 36-49 are redundant, they do nothing except increase runtime (it processes new keys but pushes them with the same key again into the args table so factually no change accomplished))
~~https://secret.liquipedia.net/commons/index.php?title=MediaWiki%3ACommon.js%2FCountdown.js&type=revision&diff=5213&oldid=5176 (you know what to replace the secret with^^)~~

How did you test this change?

dev

inside match2 on sc2 without js adjusts: https://liquipedia.net/starcraft2/User:Hjpalpha/wip10
using template countdown on secret commons including js change there (copied the necessary modules over fom normal commons): https://secret.liquipedia.net/commons/User:Hjpalpha

mind the broken logos are because secret commons is "slightly outdated" and are unrelated to my suggested changes

mbergen · 2023-07-14T10:38:54Z

~~so this explicitly allows only en as infix, why is that?~~
I misread the section that changes old keys to have the infix to it enforcing it.

hjpalpha · 2023-07-14T11:19:08Z

so this explicitly allows only en as infix, why is that?

no it doesn't only allow en as infix
i only used en in the example
inputs in old format (|youtube=, |twitch=) assume to be en though

hjpalpha · 2023-07-23T07:01:52Z

Question: should we only use non english ones in countdown module if no english stream is specified?

e.g.

if twitch_en_1 and twitch_de_1are set they both would be stored (for e.g. the app) but only the english one would be shown on the wiki
but if only twitch_de_1 is set it would show the german broadcast since no broadcast in preferred language (en) is given

would allow more precise data without cluttering up display (and would also reduce js runtime compared to displaying them all)

mbergen · 2023-07-25T07:35:36Z

Question: should we only use non english ones in countdown module if no english stream is specified?

For stuff like matchtickers that seems reasonable, but IMO all entered streams should be shown on matches, maybe inside something collapsible to not take up as much space by default. Otherwise this will lead to editors forgetting to add these, or try to add these, but won't notice in case they are added incorrect.

iMarbot · 2023-10-26T17:10:15Z

Question: should we only use non english ones in countdown module if no english stream is specified?

e.g.

if twitch_en_1 and twitch_de_1are set they both would be stored (for e.g. the app) but only the english one would be shown on the wiki

but if only twitch_de_1 is set it would show the german broadcast since no broadcast in preferred language (en) is given

would allow more precise data without cluttering up display (and would also reduce js runtime compared to displaying them all)

I agree with this :D

hjpalpha · 2023-11-02T10:14:16Z

added countdoen module and made it so that countdown module only displays english streams if english streams are set
so that language streams are only stored (as data for e.g. the app)

standard/countdown.lua

iMarbot · 2024-01-04T19:16:04Z

Comment for future hjpa :p

hjpalpha · 2024-01-04T20:59:25Z

for myself in a few weeks:

kick the legacy stuff
add the js changes

standard/links_stream.lua

- since we now have it on the git ... :) - retested on the other commons (changed from es5 to es2017 compared to what was mentioned in the PR summary)

iMarbot · 2024-03-05T18:13:33Z

Can we decide whether it's going to be afreeca or afreecatv btw? Currently it's a bit of a mess.

hjpalpha · 2024-03-05T18:20:22Z

Can we decide whether it's going to be afreeca or afreecatv btw? Currently it's a bit of a mess.

i don't particularly care
just keep in mind that it will potentionally break old pages

iMarbot · 2024-03-05T18:30:32Z

i don't particularly care just keep in mind that it will potentionally break old pages

Countdown doesn't show streams on finished matches (old pages) anyway? But we could just do a remapping in one place before everything else, no? i.e. like how you had it in the crossed out module:countdown changes in OP.

hjpalpha · 2024-03-05T19:30:02Z

i don't particularly care just keep in mind that it will potentionally break old pages

Countdown doesn't show streams on finished matches (old pages) anyway? But we could just do a remapping in one place before everything else, no? i.e. like how you had it in the crossed out module:countdown changes in OP.

totally fine with dropping one entirely
just should do the announcement of it not working anymore a few days before pushing live imo

mbergen · 2024-03-12T10:29:54Z

javascript/commons/Countdown.js

+			const icon = streamKeys[ dataSetName ];
+			const platform = dataSetName.toLowerCase();
+			if ( timerObjectNode.dataset[ 'stream' + dataSetName ] ) {
+				streamsarr.push( '<a href="' + mw.config.get( 'wgScriptPath' ) + '/Special:Stream/' + platform + '/' + liquipedia.countdown.getStreamName( timerObjectNode.dataset[ 'stream' + dataSetName ] ) + '"><i class="lp-icon lp-icon-21 lp-' + icon + '"></i></a>' );


Maybe extract the string building into a function that takes icon, dataSetName and index as parameter?

javascript/commons/Countdown.js

Co-authored-by: mbergen <mail@mbergen.de>

hjpalpha · 2024-06-26T16:36:09Z

superseded by #4372

hjpalpha added the c: standard label Jul 10, 2023

hjpalpha requested review from Rathoz, iMarbot and mbergen July 10, 2023 07:31

iMarbot approved these changes Jul 10, 2023

View reviewed changes

iMarbot reviewed Nov 2, 2023

View reviewed changes

standard/countdown.lua Show resolved Hide resolved

standard/countdown.lua Outdated Show resolved Hide resolved

hjpalpha requested a review from iMarbot January 23, 2024 12:53

iMarbot approved these changes Jan 23, 2024

View reviewed changes

hjpalpha added the stylesheets changes to stylesheets label Jan 23, 2024

Rathoz reviewed Jan 23, 2024

View reviewed changes

standard/links_stream.lua Outdated Show resolved Hide resolved

hjpalpha requested a review from Rathoz January 23, 2024 19:21

Rathoz reviewed Jan 24, 2024

View reviewed changes

standard/links_stream.lua Outdated Show resolved Hide resolved

hjpalpha requested a review from Rathoz January 24, 2024 09:31

hjpalpha added javascript Changes to JavaScript files and removed stylesheets changes to stylesheets labels Jan 25, 2024

hjpalpha and others added 7 commits January 30, 2024 17:08

Allow new stream key format as input in matches

7b4b2f3

remove empty line

610baff

code style check

1c2f4dd

add countdown module

1a4535e

shut up anno warnings

917c517

kick pandatv, play2live and smashcast legacy stuff as per review

696b796

js changes

7f65aa2

- since we now have it on the git ... :) - retested on the other commons (changed from es5 to es2017 compared to what was mentioned in the PR summary)

hjpalpha added 4 commits January 30, 2024 17:08

linter: some spaces ...

81c65dc

linter: Missing semicolon

cd6bd0f

adjust StreamKey class annos as per review

d7345e9

as per review

d0e76ce

Rathoz force-pushed the streams-in-matches branch from 8609438 to d0e76ce Compare January 30, 2024 16:08

hjpalpha and others added 3 commits March 5, 2024 17:54

add kick

b28f625

fix comment typo

5f86c1e

fix afreeca typo

8f9c518

iMarbot mentioned this pull request Mar 5, 2024

feat(coutdown): add Kick stream pages support #4065

Merged

Merge branch 'main' into streams-in-matches

8353e76

mbergen approved these changes Mar 12, 2024

View reviewed changes

Update javascript/commons/Countdown.js

1de3368

Co-authored-by: mbergen <mail@mbergen.de>

hjpalpha mentioned this pull request Jun 25, 2024

feat(MatchTicker): add new match ticker display style #4363

Merged

hjpalpha closed this Jun 26, 2024

hjpalpha deleted the streams-in-matches branch July 12, 2024 11:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow new stream key format as input in matches #3111

Allow new stream key format as input in matches #3111

hjpalpha commented Jul 10, 2023 •

edited

Loading

mbergen commented Jul 14, 2023 •

edited

Loading

hjpalpha commented Jul 14, 2023 •

edited

Loading

hjpalpha commented Jul 23, 2023

mbergen commented Jul 25, 2023

iMarbot commented Oct 26, 2023

hjpalpha commented Nov 2, 2023 •

edited

Loading

iMarbot commented Jan 4, 2024

hjpalpha commented Jan 4, 2024

iMarbot commented Mar 5, 2024

hjpalpha commented Mar 5, 2024

iMarbot commented Mar 5, 2024 •

edited

Loading

hjpalpha commented Mar 5, 2024

mbergen Mar 12, 2024

hjpalpha commented Jun 26, 2024

Allow new stream key format as input in matches #3111

Allow new stream key format as input in matches #3111

Conversation

hjpalpha commented Jul 10, 2023 • edited Loading

Summary

How did you test this change?

mbergen commented Jul 14, 2023 • edited Loading

hjpalpha commented Jul 14, 2023 • edited Loading

hjpalpha commented Jul 23, 2023

mbergen commented Jul 25, 2023

iMarbot commented Oct 26, 2023

hjpalpha commented Nov 2, 2023 • edited Loading

iMarbot commented Jan 4, 2024

hjpalpha commented Jan 4, 2024

iMarbot commented Mar 5, 2024

hjpalpha commented Mar 5, 2024

iMarbot commented Mar 5, 2024 • edited Loading

hjpalpha commented Mar 5, 2024

mbergen Mar 12, 2024

Choose a reason for hiding this comment

hjpalpha commented Jun 26, 2024

hjpalpha commented Jul 10, 2023 •

edited

Loading

mbergen commented Jul 14, 2023 •

edited

Loading

hjpalpha commented Jul 14, 2023 •

edited

Loading

hjpalpha commented Nov 2, 2023 •

edited

Loading

iMarbot commented Mar 5, 2024 •

edited

Loading