-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass system to darwinSystem rather than eval-config. #317
Conversation
This should fix #319 |
FYI, I'm not quite sure why the build failed. I've been using this successfully in my fork since I submitted this PR. |
This is a good example how NixOS/nix#3843 would simplify flakes and remove the need to hardcode system like in this case. |
@dhess could you rebase and check if tests pass? |
This allows us to specify what kind of darwinSystem we want to build, rather than determining it at evaluation time.
Done. |
I've added some design thoughts to NixOS/nix#3843 (comment) |
|
I'll try to take a look at this over the weekend. |
This PR worked perfectly for me, thank you! I think @domenkozar's error must be related to issues with specifying this fork in
The error looks what you'd get passing |
Good catch. I'm not sure how to fix this, nor whether it's even worth bothering, given that it won't be a problem once it's merged. I'll wait to hear from @LnL7, in any case. |
FWIW, |
Ah I see, now the error makes sense. It seems like the |
@dhess I can push a fix for the tests if you allow edits from maintainers. |
Sorry for being dense, but how do I do that? |
I don't see that option. Perhaps it's because the branch is from a repo owned by an org and not an individual? |
Weird, guess it must be something like that. Well you can just cherry-pick it from https://github.com/LnL7/nix-darwin/commits/flakes-test then. 😄 |
Or you could just merge your branch :) I don't care either way, whatever you prefer. |
Excellent, thanks! |
This allows us to specify what kind of darwinSystem we want to build, rather than determining it at evaluation time.