Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services.skhd): improve skhd performance by setting SHELL to dash #647

Closed
wants to merge 1 commit into from

Conversation

ajaxbits
Copy link

@ajaxbits ajaxbits commented May 2, 2023

Ensure fast performance by setting the skhd shell to dash[1].

I was experiencing very slow performance from skhd (moving between windows time ~= 1 sec), but I tried the solution outlined in this GitHub issue in the skhd repo, and it significantly improved performance (no noticeable delay).

Tested on Macbook Pro, M1 Max, OS v.12.6.5 (Monterey).

@ajaxbits ajaxbits changed the title feat: improve skhd performance by setting SHELL to dash feat(services.skhd): improve skhd performance by setting SHELL to dash May 2, 2023
@jhenahan
Copy link

jhenahan commented May 9, 2023

One issue I've run into with this approach: applications launched using skhd inherit the SHELL. For example, when launching Emacs normally I get my login shell, but if I launch it with skhd then I get dash.

@emilazy
Copy link
Collaborator

emilazy commented Jul 10, 2023

I'm a little hesitant to merge this as-is for the reason @jhenahan gave. Are you using Fish? Enabling Babelfish should speed up shell startup significantly (if you're using Home Manager you'll need to use the unstable branch to get it to use Babelfish as well):

{
  programs.fish.useBabelfish = true;
  programs.fish.babelfishPackage = pkgs.babelfish;
}

I'd like to set this by default at some point if possible, since the startup time difference is so huge.

@ajaxbits
Copy link
Author

Absolutley @emilazy, that makes a lot of sense. I'd be happy to close this PR if it's not the direction the project should take here.

And I hadn't heard about the bablefish startup time speedup! I'll try that right now, thanks

@emilazy
Copy link
Collaborator

emilazy commented Jul 11, 2023

Yeah, I think this would at least have to be a toggle option to merge, and it might not be worth it as this can be overridden in the user configuration if they're using a particularly slow shell. Ideally skhd would implement koekeishiya/skhd#277 and then we could expose an option for that.

@emilazy
Copy link
Collaborator

emilazy commented Jul 17, 2023

Closing this for now, but if skhd adds a shell option then I'd be happy to review a PR for that.

@emilazy emilazy closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants