Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix browser build sync and alive behavior for dev #175

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

marionbarker
Copy link
Contributor

  • this matches main from PR 164 but started with dev branch of LoopWorkspace
  • the code modification is identical to Fix sync alive #172 but has a different commit history

@dnzxy dnzxy mentioned this pull request Jul 20, 2024
@marionbarker
Copy link
Contributor Author

Summary

  • Successful test
  • LGTM

Detailed test record

Initial Configuration

  • Use similar procedure as with Fix browser build sync and alive behavior #164 but no need to test the cron portion
  • both marionbarker and loopdocs-tester started with main aligned with LoopKit main and dev aligned with LoopKit dev
  • configure marionbarker:dev to have the changes in this PR and to set UPSTREAM_REPO to marionbarker instead of LoopKit
  • sync loopdocs-tester to marionbarker so it has the same changes
  • make a dummy commit (single line change in testflight) so marionbarker is one commit ahead of loopdocs-tester

State of alive branches

  • Previously, I did a manual build of both main and dev for loopdocs-tester when main was aligned with LoopKit main and dev aligned with LoopKit dev
  • therefore there are 3 alive branches:
    • alive-dev
    • alive-main
    • alive

Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant