Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Image goes wrong when using direct image url. #111

Closed
kaedea opened this issue Oct 7, 2015 · 6 comments
Closed

Avatar Image goes wrong when using direct image url. #111

kaedea opened this issue Oct 7, 2015 · 6 comments

Comments

@kaedea
Copy link

kaedea commented Oct 7, 2015

Look like the following
image

I have set the domain url to
image

@chawyehsu
Copy link

You should put your avatar image into assets/images/, and use relative url, not outer url.
20151007150104

In layout/_partial/about.ejs, it generates url with theme.image_dir, which is set in theme _conifg.yml.

Or yourself edit the source, remove theme.image_dir:

<img id="about-card-picture" src="<%- theme.author.picture %>"/>

@LouisBarranqueiro
Copy link
Owner

yeah, curently you can't use an external image for your avatar. I will fix that :) I'im going to try to release a new version this WE :)

PS : @kaedea, set url to http://kaedea.com and not http://kaedea.com/

@LouisBarranqueiro
Copy link
Owner

feature added :)

@chawyehsu
Copy link

@LouisBarranqueiro the regex looks really complex, D:, why not just use .indexOf('://') >= 0.

@LouisBarranqueiro
Copy link
Owner

Yeah, the .indexOf('://') do the job like I did in sidebar.ejs, but the regex improve the control of the url and I think the performance are not so much impacted since the string is not so long. I will do some tests to check that.

@LouisBarranqueiro
Copy link
Owner

I will change to .indexOf('://'), I used this method a lot of time in this theme to test external url so... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants