Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line pickup issues #398

Closed
Resike opened this issue Feb 19, 2021 · 13 comments
Closed

Line pickup issues #398

Resike opened this issue Feb 19, 2021 · 13 comments
Labels
bug Something isn't working Info Needed More information is required

Comments

@Resike
Copy link
Contributor

Resike commented Feb 19, 2021

Typing something at the end of the file doesn't seem to get picked up the the server, when hovered a named function for example it produces no tooltip, unless you reopen the file itself.

@sumneko sumneko added the Info Needed More information is required label Feb 20, 2021
@sumneko
Copy link
Collaborator

sumneko commented Feb 20, 2021

typing-eof

I can not reproduce this.

@Resike
Copy link
Contributor Author

Resike commented Feb 21, 2021

Could this be an issue with Sublime LSP then?

o168eSdnps

Sublime Text 4 (4098)
Sublime LSP v1.2.11
Windows 7 64bit

@Resike
Copy link
Contributor Author

Resike commented Feb 21, 2021

I can also reproduce it in VSCode.

@sumneko
Copy link
Collaborator

sumneko commented Feb 21, 2021

@sumneko sumneko added the bug Something isn't working label Feb 21, 2021
@Resike
Copy link
Contributor Author

Resike commented Feb 21, 2021

VSCode:
sXEyPubK0I
file_c%3A_test.log

Sublime Text:
image
file_C_test.log

@sumneko
Copy link
Collaborator

sumneko commented Feb 22, 2021

I still cannot reproduce this, please apply this patch and show me the new log, thank you!

--- a/script/provider/provider.lua
+++ b/script/provider/provider.lua
@@ -270,6 +270,7 @@ proto.on('textDocument/didChange', function (params)
     end
     files.clearDiff(uri)
     local text = files.getText(uri) or ''
+    log.debug('didChange-param', util.dump(text), util.dump(changes))
     for _, change in ipairs(changes) do
         if change.range then
             local start, finish = files.unrange(uri, change.range)
@@ -278,6 +279,7 @@ proto.on('textDocument/didChange', function (params)
             text = change.text
         end
     end
+    log.debug('didChange-result', util.dump(text))
     files.setText(uri, text, true)
 end)

@Resike
Copy link
Contributor Author

Resike commented Feb 25, 2021

ITTWxkT54Y

file_c%3A_test.log

@sumneko
Copy link
Collaborator

sumneko commented Feb 26, 2021

Many thanks! Now I can reproduce it now!

sumneko added a commit that referenced this issue Feb 26, 2021
@sumneko
Copy link
Collaborator

sumneko commented Feb 26, 2021

Please checkout this commit and check if it works!

@Resike
Copy link
Contributor Author

Resike commented Feb 26, 2021

Seems to be good now. Thanks!

@Resike Resike closed this as completed Feb 26, 2021
@Resike Resike reopened this Feb 26, 2021
@Resike
Copy link
Contributor Author

Resike commented Feb 26, 2021

Still seems to be borked in Sublime:
fGZQrXtJNI

file_C_Test.log

sumneko added a commit that referenced this issue Mar 1, 2021
@sumneko
Copy link
Collaborator

sumneko commented Mar 1, 2021

Please help me test if this commit works!

@Resike
Copy link
Contributor Author

Resike commented Mar 2, 2021

Yeah this one seems to work properly.

@Resike Resike closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Info Needed More information is required
Projects
None yet
Development

No branches or pull requests

2 participants