Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore Cargo.lock file #49

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jun 28, 2024

@LukeMathWalker
Copy link
Owner

Mmmm since we don't provide any MSRV, I don't really see the point of committing the lockfile here.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Jun 28, 2024

it makes it easier to go back in git history and get a set of dependencies that were known to work at that point in time. often helps with git bisect and stuff like that.

@LukeMathWalker LukeMathWalker merged commit d3b8029 into LukeMathWalker:master Jun 28, 2024
4 checks passed
@LukeMathWalker
Copy link
Owner

Let's add it then, I don't have a strong opinion here.

@Turbo87 Turbo87 deleted the lockfile branch June 28, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants