Skip to content

Commit

Permalink
Clippy lints
Browse files Browse the repository at this point in the history
  • Loading branch information
LukeMathWalker committed Dec 19, 2022
1 parent 8e5b09b commit d23e48b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions src/root_span_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ impl RootSpanBuilder for DefaultRootSpanBuilder {
handle_error(span, response.status(), error.as_response_error());
} else {
let code: i32 = response.response().status().as_u16().into();
span.record("http.status_code", &code);
span.record("otel.status_code", &"OK");
span.record("http.status_code", code);
span.record("otel.status_code", "OK");
}
}
Err(error) => {
Expand All @@ -63,17 +63,17 @@ impl RootSpanBuilder for DefaultRootSpanBuilder {

fn handle_error(span: Span, status_code: StatusCode, response_error: &dyn ResponseError) {
// pre-formatting errors is a workaround for https://github.com/tokio-rs/tracing/issues/1565
let display = format!("{}", response_error);
let debug = format!("{:?}", response_error);
let display = format!("{response_error}");
let debug = format!("{response_error:?}");
span.record("exception.message", &tracing::field::display(display));
span.record("exception.details", &tracing::field::display(debug));
let code: i32 = status_code.as_u16().into();

span.record("http.status_code", &code);
span.record("http.status_code", code);

if status_code.is_client_error() {
span.record("otel.status_code", &"OK");
span.record("otel.status_code", "OK");
} else {
span.record("otel.status_code", &"ERROR");
span.record("otel.status_code", "ERROR");
}
}
2 changes: 1 addition & 1 deletion src/root_span_macro.rs
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ pub mod private {
Version::HTTP_11 => "1.1".into(),
Version::HTTP_2 => "2.0".into(),
Version::HTTP_3 => "3.0".into(),
other => format!("{:?}", other).into(),
other => format!("{other:?}").into(),
}
}

Expand Down

0 comments on commit d23e48b

Please sign in to comment.