Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include upgrade tech-type when an upgrade is available #359

Closed
lyricnz opened this issue May 17, 2024 · 2 comments
Closed

Include upgrade tech-type when an upgrade is available #359

lyricnz opened this issue May 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lyricnz
Copy link
Contributor

lyricnz commented May 17, 2024

Following on from #350 (comment) it would be nice if we could see what the target tech-type is (it's not always FTTP anymore).

Here is a dump of all tech_change_status->upgrade fields across the current results (without the _CT changes from #358 )

{'Build Finalised': Counter({'FTTP_NA': 60898, 'FW_NA': 6, 'SAT_NA': 1}),
 'Committed': Counter({'FTTP_NA': 798308}),
 'Eligible To Order': Counter({'FTTP_SA': 2333560,
                               'FTTN_CT': 156369,
                               'NULL_NA': 11702,
                               'SAT_CT': 4519,
                               'FW_CT': 2313,
                               'FTTC_CT': 546,
                               'FTTN_SA': 217,
                               'FTTB_CT': 151,
                               'HFC_CT': 20}),
 'Eligible to Order': Counter({'FTTP_NA': 446}),
 'In Design': Counter({'FTTP_NA': 561112}),
 'MDU Complex Eligible To Apply': Counter({'FTTP_NA': 803529}),
 'MDU Complex Premises In Build': Counter({'FTTP_NA': 530}),
 'New Tech Connected': Counter({'FTTN_CT': 11506,
                                'FTTC_CT': 3424,
                                'FTTB_CT': 190,
                                'FW_CT': 152,
                                'SAT_CT': 113,
                                'HFC_CT': 98,
                                'FTTP_NA': 34}),
 'Not Planned': Counter({'NULL_NA': 782722}),
 'Previous Tech Disconnected': Counter({'FTTP_NA': 175165, 'NULL_NA': 22823})}

It would be nice to see something like

image

@lyricnz
Copy link
Contributor Author

lyricnz commented May 17, 2024

If we apply all the _CT fixes, then the tally looks much nicer:

{'Build Finalised': Counter({'FTTP_NA': 63128, 'FW_NA': 6, 'SAT_NA': 1}),
 'Committed': Counter({'FTTP_NA': 799483}),
 'Eligible To Order': Counter({'FTTP_SA': 2337391,
                               'FTTP': 152611,
                               'NULL_NA': 11548,
                               'WIRELESS': 4432,
                               'FTTC': 1093,
                               'FTTN': 255,
                               'FTTN_SA': 179,
                               'SATELLITE': 3,
                               'NULL': 1}),
 'Eligible to Order': Counter({'FTTP_NA': 696}),
 'In Design': Counter({'FTTP_NA': 562712}),
 'MDU Complex Eligible To Apply': Counter({'FTTP_NA': 802915}),
 'MDU Complex Premises In Build': Counter({'FTTP_NA': 531}),
 'New Tech Connected': Counter({'FTTP': 15218,
                                'WIRELESS': 94,
                                'FTTC': 88,
                                'FTTN': 55,
                                'FTTP_NA': 33}),
 'Not Planned': Counter({'NULL_NA': 782707}),
 'Planned': Counter({'FTTP_NA': 1}),
 'Previous Tech Disconnected': Counter({'FTTP_NA': 174432, 'NULL_NA': 22441})}

@lyricnz
Copy link
Contributor Author

lyricnz commented May 17, 2024

I propose adding the inner if..then clause

                if ("tech_change_status" in feature.properties) {
                    s += "<br>Tech Change Status: " + feature.properties.tech_change_status
                    if ("upgrade" in feature.properties) {
                        s += " (" + feature.properties.upgrade.split("_")[0] + ")"
                    }
                }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants