-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show green (or another non-red) colour for upgrades available other than FTTP #361
Comments
Added a tool for dumping status -> tech -> upgrade. For 'Eligible To Order' this is:
|
Oh this is very interesting indeed. |
@LukePrior the full status -> tech -> upgrade:count dump is
|
I'm not sure on the colours especially for other upgrade which could for example be from Wireless to FTTN but would still show up as "better" then like FTTC. Or in your latest image where Satellite to FW is shown as "better" then SAT/FW. I'm not sure what the best way to approach this, maybe the behaviour is fine and we can leave as is. Some other options would be to dynamically generate for each tech/upgrade but that would need a lot of colours. |
If we were to split it out as much as possible I think we would have the following, organised "best to worst"
|
Why is Wireless->FTTN (blue) "better" than FTTC? Because red/orange is bad? |
You missed HFC->FTTP upgrade available (there are 98 of those). And satellite with/without upgrade? (there are upgrades to FTTN, FTTC, FTTP and wireless, with wireless being the most common) |
Oh the way I wrote it was listing the technology which can be upgraded to rather then the one upgrading from, not sure what is clearer. i.e. no one is getting upgraded to Satellite |
I guess it all comes down to what you're trying to show - current tech, upgrade availability / upgrade-to, etc. It's all up to |
Yeah it would be good to better understand who's using the site and what for so could then customise the experience to best suit their needs but for time being this seems like a good setup. |
@LukePrior maybe raise another issue to revisit node-colouring as a whole? This PR was attempting to show people who had non-FTTP upgrades a different colour. |
Maybe you could even have a toggle/selector that switched out getDotType() completely for a couple of different options? |
Eg
Current code has some requirements around FTTN/FTTC, and an implicit assumption that all upgrades are FTTP
The text was updated successfully, but these errors were encountered: