Add LOC ID to bubbles #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukePrior#319 add loc id to bubbles
Closed
Judging from the generation script geojson.py a feature cannot be created without a locID therefore, this PR is totally safe. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#319 add loc id to bubbles
I was going to verify every single geo location has a loc id but its been 20 minutes since I started a git clone and I'm at 4%. Don't know if it needs to be protected e.g.
( "locID" in properties ? : properties.locID : ""). If you know off the top of your head then go for it. Otherwise, I will verify it when my git clone completes (tomorrow?).