-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAAP CMR and .ops updates #213
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Note about HLS tutorial: seems to work with the .ops update, but it does like to crash on me when it pulls all of the different bands (I think it even did this before I removed it). Made note of it in the individual issue for HLS when we do VEDA updates, but I'm going to go ahead and push it here |
I'll leave a comment when I finish updating the science tutorials with any more cmr/ops changes that I can make, which should be tomorrow afternoon. After that, I'll start looking and making other edits to each individual notebook and do separate PRs |
Was it ready for review ? I did a quick review @smk0033, apart from the above comment it looks ok to me. In addition, could you reference the issue this PR is solving ? My guess is that it's https://github.com/orgs/NASA-IMPACT/projects/29?pane=issue&itemId=27143805 but I am not sure. Thanks ! |
Sure thing! I'll have the rest of the science tutorials that can be pushed soon, but thanks for looking at what I've gotten so far @emileten! I also plan to fix the links when we go through the individual tutorials after this PR, my biggest thing with this ticket was fixing cmr/.ops in the tutorials that allowed it (and that don't seem to have anything else broken besides links) |
I think that's all of the science tutorials I can go ahead and update just for this ticket. Other issues have been noted in the individual tickets under VEDA guidelines |
I think I've fixed all the links in the tutorials provided so far for this PR (please let me know if I missed any!). I also added searching_compiling_list_of_granule_ids on here, it didn't have any cmr/ops changes, but I accidentally updated it and just went with it since it was only a link and text fix. I was also able to rerun the HLS tutorial and it seemed like it processed with no issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All listed notebook links and references seem to be updated 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the link and referencing the ticket @smk0033 ! LGTM
Tutorials so far that work and can be updated to remove .ops and/or MAAP CMR. Technical and science tutorials - pushing technical first, science will follow. Github ticket for reference: https://github.com/orgs/NASA-IMPACT/projects/29?pane=issue&itemId=27143805
Other technical tutorial issues are listed here
Other science tutorial updates listed here