Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEDI L2B VEDA Guidelines #258

Merged
merged 2 commits into from
Jul 5, 2023
Merged

GEDI L2B VEDA Guidelines #258

merged 2 commits into from
Jul 5, 2023

Conversation

smk0033
Copy link
Contributor

@smk0033 smk0033 commented Jul 5, 2023

In reference to: #243

Added rendering info, new sections (Run This Notebook, About the Data and Additional Resources), and added headers throughout the tutorial since they were missing.

@smk0033 smk0033 added the documentation Improvements or additions to documentation label Jul 5, 2023
@smk0033 smk0033 self-assigned this Jul 5, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@jjfrench jjfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smk0033 smk0033 merged commit ac1a656 into develop Jul 5, 2023
@smk0033 smk0033 deleted the GEDI_L2B_VEDA branch July 5, 2023 14:51
@emileten
Copy link
Contributor

emileten commented Jul 7, 2023

super minor suggestion unrelated to the PR content in itself @smk0033, in case you had not noticed. If you link the related issue through the project board, and the issue gets moved from the board, I believe the link gets broken. E.g. the issue link in this PR is broken #219.

So maybe to ensure the link is preserved for anyone looking at the PR in the future, either of the following ? could be better (which all amount to directly link to the issue rather than the board it was added to)

@smk0033
Copy link
Contributor Author

smk0033 commented Jul 7, 2023

Thanks, @emileten! I had no idea those links were breaking😅 thanks for pointing that out and recommending fixes for them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants