Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme and intersphinx #127

Merged
merged 11 commits into from
Oct 21, 2023
Merged

Update theme and intersphinx #127

merged 11 commits into from
Oct 21, 2023

Conversation

lilyminium
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (683f600) 87.55% compared to head (c0da093) 87.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files           5        5           
  Lines         747      747           
  Branches      127      127           
=======================================
  Hits          654      654           
  Misses         56       56           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

u'Irfan Alibay,Zhiyi Wu')
copyright = u'2007-2021, ' + authors
project = "GridDataFormats"
authors = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really use an author file...

doc/source/conf.py Outdated Show resolved Hide resolved
environment.yaml Outdated Show resolved Hide resolved
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@pep8speaks
Copy link

pep8speaks commented Sep 22, 2023

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 44:80: E501 line too long (109 > 79 characters)
Line 203:5: E265 block comment should start with '# '
Line 205:5: E265 block comment should start with '# '
Line 207:5: E265 block comment should start with '# '
Line 248:80: E501 line too long (85 > 79 characters)

Comment last updated at 2023-10-21 20:01:06 UTC

lilyminium and others added 2 commits September 22, 2023 09:24
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@orbeckst orbeckst mentioned this pull request Oct 21, 2023
6 tasks
@orbeckst
Copy link
Member

I'll have a look if I can get it to work as is.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orbeckst I think this will now pick up the wrong yaml file

environment.yaml Outdated Show resolved Hide resolved
@orbeckst
Copy link
Member

Locally I can't get the sphinx stuff to install in a Python 3.12 environment:

Pinned packages:
  - python 3.12.*


Could not solve for environment specs
The following package could not be installed
└─ mdanalysis-sphinx-theme >=1.0.1  is installable and it requires
   └─ sphinx >=6.2.1,<7.0 , which requires
      └─ docutils >=0.18.1,<0.20  with the potential options
         ├─ docutils [0.18.1|0.19] would require
         │  └─ python >=3.10,<3.11.0a0 , which can be installed;
         ├─ docutils [0.18.1|0.19] would require
         │  └─ python >=3.7,<3.8.0a0 , which can be installed;
         ├─ docutils [0.18.1|0.19] would require
         │  └─ python >=3.8,<3.9.0a0 , which can be installed;
         ├─ docutils [0.18.1|0.19] would require
         │  └─ python >=3.9,<3.10.0a0 , which can be installed;
         └─ docutils [0.18.1|0.19] would require
            └─ python >=3.11,<3.12.0a0 , which can be installed.

so need to do sphinx in 3.10 or so.

@orbeckst
Copy link
Member

ok, need to pip-install sphinx_sitemap — somehow I had hoped that this was magically included in mdanalysis-sphinx-theme (but on reflection it's sensible that it isn't).

 Could not import extension sphinx_sitemap (exception: No module named 'sphinx_sitemap')

@orbeckst orbeckst marked this pull request as ready for review October 21, 2023 20:00
@orbeckst orbeckst self-assigned this Oct 21, 2023
@orbeckst orbeckst merged commit 21032fb into master Oct 21, 2023
9 checks passed
@orbeckst orbeckst deleted the switch-docs-theme branch October 21, 2023 20:25
@orbeckst
Copy link
Member

Thank you @lilyminium and also thanks @IAlibay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants