Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRZ reader default dt value differs from base default value #3257

Closed
IAlibay opened this issue May 2, 2021 · 2 comments · Fixed by #3488
Closed

TRZ reader default dt value differs from base default value #3257

IAlibay opened this issue May 2, 2021 · 2 comments · Fixed by #3488

Comments

@IAlibay
Copy link
Member

IAlibay commented May 2, 2021

Expected behavior

The default value for dt is the same across all readers.

Actual behavior

As pointed out in #3256 the TRZ reader defaults to 0 instead of the base value of 1.0. I propose in 2.1.0 that we just change it to align the behaviour with the other readers (as per the warning I added in #3256).

@IAlibay IAlibay added this to the 2.1.0 milestone May 2, 2021
@richardjgowers
Copy link
Member

The 0 value only happens when there's only one frame so this is very minor. But yeah we can fix this once 2.0 is out the door.

@IAlibay
Copy link
Member Author

IAlibay commented Jun 21, 2021

I'm fixing some TRZ behaviour somewhere else [for 2.0.0], I might just throw the warning in there so we can make 2.1.0 the "get rid of all the warnings" release.

IAlibay added a commit that referenced this issue Dec 29, 2021
Fixes #3257 
## Work done in this PR
* Switch TRZ dt behaviour to return 1.0 when not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants