Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing for core.Selections #362

Closed
richardjgowers opened this issue Jul 22, 2015 · 2 comments
Closed

Testing for core.Selections #362

richardjgowers opened this issue Jul 22, 2015 · 2 comments
Assignees
@richardjgowers
Labels
Component-Selections testing
Milestone
0.13

Comments

@richardjgowers
Copy link
Member

Coverage for the Selection system is 79%, it looks like many distance based selections have been missed out.

I know @mnmelo is working on Selections currently, so may wait on him commenting before writing some new tests.
@richardjgowers richardjgowers added this to the 0.12 milestone Jul 22, 2015
@orbeckst orbeckst mentioned this issue Jul 23, 2015
Closed
@mnmelo mnmelo mentioned this issue Jul 27, 2015
Open
@mnmelo
Copy link
Member

mnmelo commented Jul 27, 2015

I just opened #371 on the overhaul of the selection module.

Either we wait until then to expand testing, or push for it asap, so that the overhaul occurs already under better testing.

@orbeckst
Copy link
Member

We need the tests one way or the other and before we get #371 into the mainline I'd actually like to know that the old system is fully working. So I'd say there's no harm in adding a test whenever you feel like ;-).

@richardjgowers richardjgowers self-assigned this Oct 30, 2015
richardjgowers added a commit that referenced this issue Oct 30, 2015
@richardjgowers
Removed unused/orphaned code from core/Selections
dc84819 
Start of Issue #362

Removed:
CASelection (wasn't accessible anyway?)
BondedSelection (wasn't fully implemented)
NUCLEICXSTAL (only the name existed?)
@richardjgowers richardjgowers mentioned this issue Oct 30, 2015
Merged
richardjgowers added a commit that referenced this issue Nov 2, 2015
@richardjgowers
Reworked spherical selections, more efficient
88f4798 
Added distance selection tests for with/without PBC

Finishes Issue #362
orbeckst added a commit that referenced this issue Nov 3, 2015
@orbeckst
Merge pull request #514 from MDAnalysis/issue-362
35fb1b0 
updates/fixes for selections (related to #362)

- unused code was removed
- bonded selections fully implemented
- performance improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardjgowers richardjgowers

Labels
Component-Selections testing
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
3 participants
@orbeckst @richardjgowers @mnmelo