Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triclinic cells #1674

Merged
merged 4 commits into from
Sep 26, 2017
Merged

Triclinic cells #1674

merged 4 commits into from
Sep 26, 2017

Conversation

kain88-de
Copy link
Member

@kain88-de kain88-de commented Sep 24, 2017

Fixes #1475

Changes made in this Pull Request:

  • use a explicit image search algorithm
  • straight forward implementation

It still needs some more rigorous tests. I can do that tomorrow. I have not checked the performance that this code produces right now.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@kain88-de kain88-de force-pushed the triclinic-cells branch 3 times, most recently from e70a0db to 730842e Compare September 25, 2017 17:12
@kain88-de
Copy link
Member Author

failures due to #1675

Copy link
Member

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as a quick fix

@kain88-de
Copy link
Member Author

update against develop. Let see if it passes travis

@kain88-de kain88-de merged commit 88b6c20 into develop Sep 26, 2017
@kain88-de kain88-de deleted the triclinic-cells branch September 26, 2017 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants