Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs code block for lineardensity #3616

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Fix docs code block for lineardensity #3616

merged 5 commits into from
Apr 9, 2022

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 9, 2022

Quick fix since CI is failing now.

This is partly on me since it was a suggested change from review in #3572

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay changed the title Fix scode block docs for lineardensity Fix sode block docs for lineardensity Apr 9, 2022
@IAlibay IAlibay changed the title Fix sode block docs for lineardensity Fix docs code block for lineardensity Apr 9, 2022
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #3616 (ebe0bf1) into develop (7c166c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3616   +/-   ##
========================================
  Coverage    94.23%   94.23%           
========================================
  Files          190      190           
  Lines        24752    24752           
  Branches      3329     3329           
========================================
  Hits         23324    23324           
  Misses        1380     1380           
  Partials        48       48           
Impacted Files Coverage Δ
package/MDAnalysis/analysis/lineardensity.py 87.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c166c0...ebe0bf1. Read the comment docs.

of the system:

Alternatively, the other types of groupings can be selected using the
``grouping`` keyword. For example to calculated the density based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick that this should be calculate rather than calculated - but otherwise lgtm!

@IAlibay
Copy link
Member Author

IAlibay commented Apr 9, 2022

Thanks @fiona-naughton!

@IAlibay IAlibay merged commit 8cd0a94 into develop Apr 9, 2022
@IAlibay IAlibay deleted the hotfix-docs branch April 9, 2022 07:47
@IAlibay IAlibay added the defect label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants