-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize continuous check in chain trajectory #3849
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3849 +/- ##
========================================
Coverage 93.60% 93.60%
========================================
Files 193 193
Lines 25146 25152 +6
Branches 4055 4055
========================================
+ Hits 23538 23544 +6
Misses 1092 1092
Partials 516 516
☔ View full report in Codecov by Sentry. |
Linter Bot Results:Hi @jaclark5! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
@MDAnalysis/coredevs I'm curious to know your thoughts on this change |
Fixes #3546
Changes made in this Pull Request:
Note that the overwritten method in the LAMMPS reader was a solution that was integrated into my personal working version with very ugly if statements. I think a solution like this will keep things clean.
PR Checklist