Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access hbonds results through new results member in count_by_ids() and count_by_type() #3876

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Access hbonds results through new results member in count_by_ids() and count_by_type() #3876

merged 1 commit into from
Oct 25, 2022

Conversation

pgbarletta
Copy link
Contributor

Hi!
Quick PR since this makes User Guide tests with nbval fail due to the UserWarning being thrown.

Fixes:
count_by_ids() and count_by_type() throw a deprecation warning for accessing the hbonds attribute directly.

PR Checklist

  • [NO] Tests?
  • [NO] Docs?
  • [YES] CHANGELOG updated?
  • [NO] Issue raised/referenced?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 94.35% // Head: 94.35% // No change to project coverage 👍

Coverage data is based on head (1ee2015) compared to base (d67c1af).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3876   +/-   ##
========================================
  Coverage    94.35%   94.35%           
========================================
  Files          194      194           
  Lines        25031    25031           
  Branches      3374     3374           
========================================
  Hits         23617    23617           
  Misses        1365     1365           
  Partials        49       49           
Impacted Files Coverage Δ
...DAnalysis/analysis/hydrogenbonds/hbond_analysis.py 98.74% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@IAlibay IAlibay merged commit b891157 into MDAnalysis:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants