Deprecate nucleicacids pair distances results in favour of results.pair_distances [Issue 3744] #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MDAnalysis/coredevs - last one on the todo list for 2.4.0 |
Codecov ReportBase: 94.41% // Head: 94.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #3958 +/- ##
===========================================
+ Coverage 94.41% 94.44% +0.03%
===========================================
Files 195 195
Lines 25423 25438 +15
Branches 3526 3527 +1
===========================================
+ Hits 24003 24026 +23
+ Misses 1376 1368 -8
Partials 44 44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
orbeckst
requested changes
Dec 15, 2022
Always good to ask for more tests, turns out there were 3 cases I had overlooked! |
orbeckst
approved these changes
Dec 16, 2022
| self.results['times'] = np.array(self._times) | ||
| for i in range(self._n_sel): | ||
| self.results[i] = np.array(self._res_dict[i]) | ||
| self.results['times'] = np.array(self.times) |
This was referenced Dec 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3744
A bit of a hack on Results, but thankfully we were only deprecating the one thing.
Changes made in this Pull Request:
resultsis deprecated in favor ofresults.pair_distances. To be removed in v2.5.0PR Checklist