Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctest for MDAnalysis.analysis.encore.similarity #4021

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

chrispfae
Copy link
Contributor

@chrispfae chrispfae commented Feb 7, 2023

Towards #3925 for MDAnalysis.analysis.encore.similarity

Changes made in this Pull Request:

  • Update the docstrings in MDAnalysis.analysis.encode.similarity so that the doctests pass for this particular file

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 93.52% // Head: 93.53% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f5637fe) compared to base (096f799).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4021      +/-   ##
===========================================
+ Coverage    93.52%   93.53%   +0.01%     
===========================================
  Files          190      191       +1     
  Lines        25028    25063      +35     
  Branches      3542     3548       +6     
===========================================
+ Hits         23407    23443      +36     
+ Misses        1100     1099       -1     
  Partials       521      521              
Impacted Files Coverage Δ
package/MDAnalysis/analysis/encore/similarity.py 85.62% <ø> (ø)
package/MDAnalysis/core/topology.py 98.88% <0.00%> (ø)
package/MDAnalysis/lib/_distopia.py 100.00% <0.00%> (ø)
package/MDAnalysis/auxiliary/EDR.py 98.91% <0.00%> (+0.01%) ⬆️
package/MDAnalysis/lib/distances.py 97.68% <0.00%> (+0.06%) ⬆️
package/MDAnalysis/auxiliary/base.py 92.04% <0.00%> (+0.11%) ⬆️
MDAnalysisTests/auxiliary/base.py 89.85% <0.00%> (+0.11%) ⬆️
MDAnalysisTests/coordinates/base.py 94.63% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, please just fix the flake8 line size that darker complains about

package/MDAnalysis/analysis/encore/similarity.py:1351:89: E501 line too long (121 > 88 characters) [flake8] 

@orbeckst orbeckst self-assigned this Feb 24, 2023
@orbeckst orbeckst merged commit c8c806d into MDAnalysis:develop Feb 24, 2023
@orbeckst
Copy link
Member

Thank you, @chrispfae !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants