Add progress bar keywords #4085
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4085 +/- ##
========================================
Coverage 93.58% 93.58%
========================================
Files 192 192
Lines 25133 25133
Branches 4056 4056
========================================
Hits 23520 23520
Misses 1093 1093
Partials 520 520
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Hi everyone, I'm not entirely sure what to do with the failing tests -- afais all of them fail with:
error during codecov report upload, so presumably issue is not with my code. Locally all tests run successfully. |
|
@marinegor yes not your fault, codecov is super flaky. Please fix conflicts and then ill review :) |
|
Hey @hmacdope I wonder what would be the best way to confidently resolve the "package/AUTHORS" merge conflict -- I pulled upstream & resolved conflict, but since new contributions keep coming to the |
|
You will have to update your PR every time develop changes, unfortunately thats just a byproduct of how distributed code development works. |
|
Ah, it's fine then!
Could you please review the PR then regardless of the merge conflicts, which happen to be only in the AUTHORS file?
|
|
Sorry if a few comments are outdated already. I didn't realize I need to submit my review. I thought "pending" means pending for feedback :-) |
marinegor
requested review from
yuxuanzhuang and
hmacdope
and removed request for
yuxuanzhuang and
hmacdope
|
I apologize for the little mess with requesting code -- hope you didn't get much annoying notifications about it :) |
Linter Bot Results:Hi @marinegor! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Update of AUTHORS and CHANGELOG with inferred author contributions.
* Removed duplicate mattwthompson in 0.20.0 changelog entry.: mattwthompson was placed twice by accident, this removes this duplication.
* Addition of missing authors.
An retrospective analysis of the authors found via `git shortlog -s -n --email --branches="develop"` found several commits by authors which were not present in the `AUTHORS.md` file.
- Zhenbo Li: commited via PR: Started tests for gnm. #803 and Make Travis run tests on OSX. #771,
- Jenna M. Swarthout via PR Update CoC according to suggestions from current CoC committee #4289 and Point to new reporting form link (owned by conduct@mdanalysis.org) #4298,
- Bradley Dice via PR Fix GSD Windows compatibility #2384 ,
- David Minh via PR #2668
There seemed to be no indications in the above mentioned PRs that the author did not want to be in the authors file, it looks like it was just forgotten.
* Addition of missing entries from the changelog
Continued cross referencing of the git shortlog output but also accounting for the changelog identified several individuals that had not been included in the changelog entries for the release they contributed under. They were added to the relevant entry of the changelog based on the merge commit date.
Please note that for Tone Bengsten, we a) had no github handle (so they were assigned @tbengtsen), and b) no specific commit. Given we know that this individual was including alongside the encore merge, they were assigned to the 0.16.0 release.
* Update CHANGELOG
* PR #1218
* PR #1284 and #1408
* PR #4109
* based on git history
* PRs #803 and #771 (author addition, changelog addition)
* PR #2255 and #2221
* PR #1225
* PR #4289 and #4298
* PR #4031
* PR #4085
* PR #3635
* PR #2356
* PR #2559
* No GH handle - Encore author addition @tbengtsen
* PR #4184
* PR #2614
* PR #2219
* PR #2384
* PR #2668
* Add missing entry for Jenna
Thanks to @fiona-naughton for helping out with digging into this data :)
Co-authored-by: Fiona Naughton <fiona@mdanalysis.org>
Co-authored-by: Oliver Beckstein <orbeckst@mdanalysis.org>
Fixes #3190
Changes made in this Pull Request:
pbar_kwargsargument to theAnalysisBase.runmethodThis presumably fixes the comments raised in this PR which was closed earlier, since the keyword-only mechanism prevents capturing other arguments during dictionary unpacking.
PR Checklist
📚 Documentation preview 📚: https://readthedocs-preview--4085.org.readthedocs.build/en/4085/