Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29, raise Python to 3.9 #4115

Merged
merged 6 commits into from
Apr 8, 2023
Merged

NEP29, raise Python to 3.9 #4115

merged 6 commits into from
Apr 8, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 5, 2023

Towards 2.5.0 release

We won't release until the 14th (at least I'm not planning to do a release over Easter holidays), so I think we can safely say we'll bump things up to Python 3.9 in line with NEP29.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://readthedocs-preview--4115.org.readthedocs.build/en/4115/

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

package/CHANGELOG Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fd978d2) 93.59% compared to head (228f892) 93.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4115   +/-   ##
========================================
  Coverage    93.59%   93.59%           
========================================
  Files          192      192           
  Lines        25134    25134           
  Branches      4056     4056           
========================================
  Hits         23524    23524           
  Misses        1092     1092           
  Partials       518      518           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @RMeli for doing the actual reviewing

@orbeckst
Copy link
Member

orbeckst commented Apr 6, 2023

Presumably, a bunch of secondary docs might need updating as well but I suppose we do this when it shows up.

@orbeckst
Copy link
Member

orbeckst commented Apr 6, 2023

Azure 3.9 32bit is unhappy

ERROR: Could not find a version that satisfies the requirement h5py (from versions: none)

@IAlibay
Copy link
Member Author

IAlibay commented Apr 6, 2023

yeah turns out that h5py hasn't released 32bit binaries for py3.9+

I'm just going to skip that pip install in that case.

@IAlibay
Copy link
Member Author

IAlibay commented Apr 6, 2023

Presumably, a bunch of secondary docs might need updating as well but I suppose we do this when it shows up.

afaik nothing in this repo, mostly userguide... which needs a good update

Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, pyproject.toml is always the trickiest to be sure about/parse, but seems sensible I think.

@tylerjereddy tylerjereddy merged commit a440165 into develop Apr 8, 2023
@tylerjereddy
Copy link
Member

NumPy and SciPy have also dropped 3.8 on their main branches.

@tylerjereddy tylerjereddy deleted the nep29-python39 branch April 8, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants