Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate hole2 class in favour of MDAKit #4200

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Deprecate hole2 class in favour of MDAKit #4200

merged 2 commits into from
Jul 16, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 16, 2023

Fixes #4179

Changes made in this Pull Request:

  • HOLE2 is now deprecated and will be removed in version 3.0

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://mdanalysis--4200.org.readthedocs.build/en/4200/

@github-actions
Copy link

github-actions bot commented Jul 16, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/5566612976/jobs/10167857069


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e39563) 93.61% compared to head (fee090d) 93.61%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4200   +/-   ##
========================================
  Coverage    93.61%   93.61%           
========================================
  Files          193      193           
  Lines        25170    25174    +4     
  Branches      4059     4060    +1     
========================================
+ Hits         23562    23566    +4     
  Misses        1092     1092           
  Partials       516      516           
Impacted Files Coverage Δ
package/MDAnalysis/analysis/hole2/hole.py 83.07% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IAlibay IAlibay merged commit e3523cf into develop Jul 16, 2023
23 checks passed
@RMeli RMeli deleted the deprecate-hole2 branch August 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate HOLE2 in favour of MDAKit
2 participants