Fix Boltzmann typo in units.py
#4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update `package/MDAnalysis/analysis/dielectric.py`, `package/MDAnalysis/units.py`, and `testsuite/MDAnalysisTests/utils/test_units.py` to reflect correct spelling
Linter Bot Results:Hi @xhgchen! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
RMeli
approved these changes
Jul 28, 2023
RMeli
requested changes
Jul 28, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4214 +/- ##
========================================
Coverage 93.62% 93.62%
========================================
Files 193 193
Lines 25295 25295
Branches 4063 4063
========================================
Hits 23683 23683
Misses 1096 1096
Partials 516 516
☔ View full report in Codecov by Sentry. |
RMeli
approved these changes
Jul 28, 2023
|
ok, that's enough CI flushed for the typo fix, in it goes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4213
Changes made in this Pull Request:
package/MDAnalysis/analysis/dielectric.py,package/MDAnalysis/units.py, andtestsuite/MDAnalysisTests/utils/test_units.pyto reflect correct spelling
📚 Documentation preview 📚: https://mdanalysis--4214.org.readthedocs.build/en/4214/