Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses, make it LGPLv2.1+ contributions going forward #4219

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 30, 2023

This license reconciles long standing issues with the way in which the MDAnalysis package was licensed.

Going forward, until such a time as the codebase is suitably relicensed, the MDAnalysis library will be packaged under the terms of the GPLv3 or any later version.

Any new contributions will be made under the conditions of the LGPLv2.1+.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://mdanalysis--4219.org.readthedocs.build/en/4219/

@IAlibay
Copy link
Member Author

IAlibay commented Jul 30, 2023

@MDAnalysis/coredevs I'm going to ask for a PR freeze until we merge this. Once this is merged we then need to make sure that all ongoing PRs agree to license their code under the terms of the LGPLv2.1 and the developer certificate of origin.

@github-actions
Copy link

github-actions bot commented Jul 30, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick comments before dosing off. Thanks @IAlibay!

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
package/doc/sphinx/source/index.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ac30c88) 93.62% compared to head (308e33e) 93.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4219      +/-   ##
===========================================
- Coverage    93.62%   93.62%   -0.01%     
===========================================
  Files          193      179      -14     
  Lines        25294    24190    -1104     
  Branches      4063     4063              
===========================================
- Hits         23682    22648    -1034     
+ Misses        1096     1026      -70     
  Partials       516      516              

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks Irfan.

package/doc/sphinx/source/index.rst Outdated Show resolved Hide resolved
@IAlibay IAlibay requested a review from lilyminium July 30, 2023 23:49
@IAlibay
Copy link
Member Author

IAlibay commented Jul 31, 2023

@MDAnalysis/coredevs this is a big operational change, can I please have at least a couple more thumbs up before this gets merged?

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @IAlibay, thanks for all your hard work. Very much appreciated.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you please add a CHANGELOG entry, too?

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@IAlibay IAlibay requested a review from orbeckst July 31, 2023 17:21
@IAlibay
Copy link
Member Author

IAlibay commented Jul 31, 2023

Thanks all - @orbeckst can I ask for a quick re-review and then we can go ahead and merge (that's enough approving votes).

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my end. Thank you!

We do need a blog post as the follow up to https://www.mdanalysis.org/2022/11/07/relicensing in order to explain what we are doing. When we have the URL we can put it into the CHANGELOG retrospectively. But I am not going to hold up the PR for a blog post.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 31, 2023

Thanks @orbeckst - yeah I just decided to get this done so that we don't accrue any further GPLv2+ contributions. The blog post will be next but might take a bit longer.

@IAlibay IAlibay merged commit 44733fc into develop Jul 31, 2023
19 of 23 checks passed
@IAlibay IAlibay deleted the license-fix branch July 31, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants