Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre release 2.6.0 #4241

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Pre release 2.6.0 #4241

merged 2 commits into from
Aug 15, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 15, 2023

Changes made in this Pull Request:

  • The usual stuff for a new release - we are in a code freeze as soon as this is done.
  • Add in upper pins on NumPy so we don't have folks using 2.0 when it comes out.

PR Checklist

  • CHANGELOG updated?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4241.org.readthedocs.build/en/4241/

@github-actions
Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b21478f) 93.62% compared to head (2aa9c59) 93.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4241     +/-   ##
==========================================
  Coverage    93.62%   93.62%             
==========================================
  Files          179      193     +14     
  Lines        24199    25304   +1105     
  Branches      4064     4064             
==========================================
+ Hits         22657    23692   +1035     
- Misses        1026     1096     +70     
  Partials       516      516             
Files Changed Coverage Δ
package/MDAnalysis/version.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay changed the title [HOLD #4198] Pre release 2.6.0 Pre release 2.6.0 Aug 15, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Aug 15, 2023

@MDAnalysis/coredevs can I have a quick thumbs up here?

see here for tthe relevant step in the release process: https://userguide.mdanalysis.org/dev/preparing_releases_and_hotfixes.html#getting-the-develop-branch-ready-for-a-release

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess the list of relevant files to be changed in the User Guide needs to be updated?

@IAlibay
Copy link
Member Author

IAlibay commented Aug 15, 2023

LGTM, but I guess the list of relevant files to be changed in the User Guide needs to be updated?

Ah thanks for pointing it out, looks like I deleted the meta.yaml a couple of PRs back. I'll open a PR there.

@IAlibay IAlibay merged commit a603475 into develop Aug 15, 2023
23 checks passed
@IAlibay IAlibay deleted the pre-release-2.6.0 branch August 15, 2023 16:06
@IAlibay IAlibay mentioned this pull request Aug 28, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants