woper.jl : purge NPSS, other updates #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aditeyashukla
commented
Feb 9, 2024
aditeyashukla
commented
- Removed NPSS
- Changed function to take ac and specific off design mission to run
- option to save off design mission returned values
- initeng changed to bool
- cleaned up code a bit
askprash
reviewed
Feb 9, 2024
src/mission/woper.jl
Outdated
| parm = ac.parm[:,mi:mi] | ||
| para = ac.para[:,:,mi:mi] | ||
| pare = ac.pare[:,:,mi:mi] | ||
| parad = ac.para[:,:,1:1] |
There was a problem hiding this comment.
This will create copies of the array, making it slower. Could use the new parad = ac.parad which directly gives a view of the array. Similarly ac.pared; ac.parmd etc should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.