Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO bomb: #20

Merged
merged 39 commits into from
Mar 21, 2024
Merged

IO bomb: #20

merged 39 commits into from
Mar 21, 2024

Conversation

argonaut22
Copy link
Collaborator

@argonaut22 argonaut22 commented Feb 11, 2024

  • added quicksaves and quickloads of aircraft
  • added save_model to save to output readable toml's a la read_input
  • edited read_input to handle multi-mission and multi-point specs
  • added par_array_operations.jl for convenient array manipulations (e.g., array2nestedvector())
  • added convenience aircraft import fxn's, read_mdl() and read_jl() in read_externals.jl
  • added output_csv(). able to specify flight points, missions, par_array indices, to be written to csv. has logic for appending multiple aircraft to a single csv if outputs are consistent.
  • added field to aircraft struct: sized = [true/false] as a sizing flag
  • docstrings throughout (doc page and examples forthcoming)
  • misc bugs and tweaks

… tasopt.jl to files, moved fns to par_array_opers
@argonaut22 argonaut22 marked this pull request as ready for review February 11, 2024 17:54
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 82.41431% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 73.84%. Comparing base (ffe41de) to head (5c6ee55).

Files Patch % Lines
src/IO/save_model.jl 80.52% 82 Missing ⚠️
src/IO/output_csv.jl 80.26% 15 Missing ⚠️
src/IO/read_externals.jl 0.00% 13 Missing ⚠️
src/IO/par_array_opers.jl 86.95% 6 Missing ⚠️
src/IO/quicksave_load.jl 96.87% 1 Missing ⚠️
src/IO/read_input.jl 98.70% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   73.10%   73.84%   +0.74%     
==========================================
  Files          64       68       +4     
  Lines       12373    12906     +533     
==========================================
+ Hits         9045     9531     +486     
- Misses       3328     3375      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askprash
Copy link
Member

@argonaut22 I just pulled in another PR #18 which have caused a few merge conflicts. Could you please resolve these?

@askprash askprash marked this pull request as draft March 14, 2024 15:24
@argonaut22 argonaut22 marked this pull request as ready for review March 17, 2024 06:20
Copy link
Member

@askprash askprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Jonas! Looks pretty great overall! ✨ Left a few minor comments!

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
src/IO/IO_samples/777TFinput_edited.jl Outdated Show resolved Hide resolved
example/example_drela_run.jl Outdated Show resolved Hide resolved
example/example_TF_run.jl Outdated Show resolved Hide resolved
src/IO/par_array_opers.jl Outdated Show resolved Hide resolved
src/misc/aircraft.jl Show resolved Hide resolved
example/example_drela_run.jl Outdated Show resolved Hide resolved
src/TASOPT.jl Show resolved Hide resolved
src/IO/read_externals.jl Show resolved Hide resolved
@askprash askprash merged commit 9e5d0cf into MIT-LAE:main Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants