Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cabin layout and cryogenic fuel properties #25

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Cabin layout and cryogenic fuel properties #25

merged 5 commits into from
Mar 27, 2024

Conversation

ngomezve
Copy link
Contributor

  • The cabin and fuselage length can be optionally sized for the maximum number of passengers.
  • The cabin can have two decks.
  • The user no longer has to specify fuel temperature and density with cryogenic fuels. These are calculated in read_input().

askprash
askprash requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@askprash askprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌🏽 Just one minor thing I noticed re organization. Might be best to move the fuel property function to src/fuel.

src/IO/read_input.jl Outdated Show resolved Hide resolved
@askprash askprash added the enhancement New feature or request label Mar 27, 2024
@askprash askprash merged commit e70d62b into MIT-LAE:main Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askprash askprash askprash approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngomezve @askprash