Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved models for cryogenic fuel boiloff #29

Merged
merged 91 commits into from
Apr 16, 2024
Merged

Improved models for cryogenic fuel boiloff #29

merged 91 commits into from
Apr 16, 2024

Conversation

ngomezve
Copy link
Contributor

@ngomezve ngomezve commented Apr 2, 2024 •
edited
Loading

This PR applies some minor improvements to the models for cryogenic fuels:

  • Boiloff fuel is only vented when it would result in an increase in tank pressure (if the volume of the boiloff gas at saturation is greater than the volume that is made available by liquid boiloff and fuel burn).
  • The mass of the ullage gas inside the tank is now accounted for.
  • The latent heat of vaporization of hydrogen and methane is now a function of tank pressure.
  • Added Mylar as a material option for the insulation, specifically for vapor barriers.
  • Font size in tank diagrams for docs has been increased.

ngomezve and others added 30 commits March 11, 2024 17:25
@ngomezve
cryo fuel temp and dens removed from inputs
0d2c6c0
@ngomezve
fuselage sizing for maxpax; seat dims are inputs
a017123
@ngomezve
added support for double decker
0e3bedf
@ngomezve
changed tank structural sizing for compliance with ASME code
5c20d86
@ngomezve
updated fuel tank test for ASME compliant model
9ffb78f
@ngomezve
started updating tank inputs
e91d0f1
@ngomezve
Update tanksize.jl
17b88c8
@ngomezve
fixed bug + updated func comments
99dc03d
@ngomezve
removed packages from tank test
6012706
@ngomezve
turned ullage fraction into user input
e1abe44
@ngomezve
Merge branch 'MIT-LAE:main' into fuel_tank
1153f51
@ngomezve
Merge branch 'MIT-LAE:main' into tank_dev
1628ee9
@ngomezve
created double wall dev file + changed notation in tankWmech
c30801f
@ngomezve
change notation in default_input + got old doubletank to run
11c4d38
@ngomezve
started using tankWmech in double tank
e3cb1ff
@ngomezve
fixed small bug in ftankstiff
9d70541
@ngomezve
neater fuselage tank structure with more parameters
a344b91
@ngomezve
bug fixes when changing struct params
9ce7682
@ngomezve
cleaned function descriptions
7902b37
@ngomezve
Update default_input.toml
c8f6bd0
@ngomezve
started to add vacuum as insul option in tankWthermal
f337326
@ngomezve
renamed tankWmech() to size_inner_tank()
c7b412d
@ngomezve
bug fixes in vacuum tank model
0a29fa0
@ngomezve
flag to size insulation for boiloff + removed hconvgas
c8d6ba0
@ngomezve
modernized tankWthermal and introduced it in tanksize
5b4b47e
@ngomezve
introduced short cylinder model in size_outer_tank
3ff51c7
@ngomezve
reordered inputs + better Al2219 properties
1e1d898
@ngomezve
recovered old doublewalltank + started optimizing stiffeners
3d6d345
@ngomezve
preparing to eliminate redundant code
507c671
@ngomezve
outer tank optimization is working
5fbf093
ngomezve and others added 18 commits March 28, 2024 12:21
@ngomezve
added mylar as insulation opt for vapor layers
79c7f66
@ngomezve
Merge branch 'MIT-LAE:main' into tank_dev
dbca7d1
@ngomezve
simplified FFC calc in mission!
dc4e445
@ngomezve
fixed bug geom vars not updated
bde146e
@ngomezve
fixed bug geom vars not updated
3fed201
@ngomezve
Merge branch 'main' into fuel_tank
b3fceb2
@ngomezve
Merge branch 'fuel_tank' into tank_dev
160904d
@ngomezve
increased font in tank diagrams
4ec39a2
@ngomezve
better saturation fuel properties
b790e58
@ngomezve
better model for fuel venting
3e50fc7
@ngomezve
better density and enthalpy of vap for cryo fuels
1679ca7
@ngomezve
removed println from mission()
0e235ef
@ngomezve
rewrote fuel calc in mission! for clarity
401acb8
@ngomezve
integrated new fuel_properties in read_input
4aedc54
@ngomezve
Merge branch 'fuel_dev' into tank_dev
da3cf26
@ngomezve
better latent heat of vaporization in tank models
ee50b6d
@ngomezve
Merge branch 'tank_dev' into fuel_tank
d5129fe
@ngomezve
Merge branch 'MIT-LAE:main' into fuel_tank
28cc2aa
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.76%. Comparing base (c224dd9) to head (5b1a55b).

Files Patch % Lines
src/IO/read_input.jl 0.00% 4 Missing ⚠️
src/structures/tankWthermal.jl 60.00% 4 Missing ⚠️
src/structures/tankWmech.jl 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   74.73%   74.76%   +0.03%     
==========================================
  Files          69       69              
  Lines       13089    13111      +22     
==========================================
+ Hits         9782     9803      +21     
- Misses       3307     3308       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve ngomezve marked this pull request as draft April 2, 2024 15:48
@ngomezve
Copy link
Contributor Author

ngomezve commented Apr 2, 2024

I converted the PR back to draft to increase test coverage based on Codecov report.

@ngomezve ngomezve marked this pull request as ready for review April 2, 2024 21:23
@ngomezve ngomezve changed the base branch from main to joss April 4, 2024 13:46
@ngomezve ngomezve changed the base branch from joss to main April 4, 2024 13:46
@askprash askprash merged commit 9d8ef16 into MIT-LAE:main Apr 16, 2024
3 checks passed
askprash pushed a commit to askprash/TASOPT.jl that referenced this pull request May 3, 2024
@ngomezve @askprash
Improved models for cryogenic fuel boiloff (MIT-LAE#29)
02dca5a 
* better saturation fuel properties

* better model for fuel venting

* removed println from mission()

* rewrote fuel calc in mission! for clarity

* added mylar as insulation opt for vapor layers

* simplified FFC calc in mission!

* fixed bug geom vars not updated

* increased font in tank diagrams

* better saturation fuel properties

* better model for fuel venting

* better density and enthalpy of vap for cryo fuels

* removed println from mission()

* rewrote fuel calc in mission! for clarity

* integrated new fuel_properties in read_input

* better latent heat of vaporization in tank models

* bug fix + new test for fuel_properties

* accounted for mass of ullage gas in tank

* updated tests after changing ullage calculation

* updated docs to reflect new ullage method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngomezve @codecov-commenter @askprash