Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryogenic fuels: hold times, more insulation options and tests #56

Merged
merged 12 commits into from
Jun 21, 2024

Conversation

ngomezve
Copy link
Contributor

@ngomezve ngomezve commented May 31, 2024

This PR addresses the models for aircraft with cryogenic fuels in insulated tanks:

  • The effect of hold times at departure or arrival can now be modeled; this will affect fuel venting.
  • Radiation to the fuselage has been eliminated from the thermal models; the effect was negligible and the model was sketchy.
  • Added vacuum microspheres as an insulation option.
  • Fixed a bug in the balance-field calculation with heat exchangers, wherein the effect of the heat exchanger was not being accounted for.
  • Fixed a small bug in the tank time integration, which could ignore the takeoff time.
  • Minor changes to gasfun.jl and the models in CryoTank to eliminate type promotion and improve speed.
  • New test for hydrogen aircraft sizing.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (78ba4b2) to head (10f25f8).
Report is 5 commits behind head on main.

Files Patch % Lines
src/IO/save_model.jl 0.00% 7 Missing ⚠️
src/cryo_tank/tankWmech.jl 0.00% 2 Missing ⚠️
src/cryo_tank/tankWthermal.jl 66.66% 2 Missing ⚠️
src/cryo_tank/tanktools.jl 90.90% 2 Missing ⚠️
src/cryo_tank/pressure.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   76.41%   78.09%   +1.67%     
==========================================
  Files          69       71       +2     
  Lines       13169    13424     +255     
==========================================
+ Hits        10063    10483     +420     
+ Misses       3106     2941     -165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve ngomezve marked this pull request as ready for review June 3, 2024 21:04
@@ -74,7 +75,9 @@ function tanksize!(fuse_tank, z::Float64, Mair::Float64, xftank::Float64,
Winner_tot, lcyl1, tskin, Rinnertank, Vfuel, Winnertank, Wfuel_tot, Winsul_sum, t_head, Whead, Wcyl, Wstiff, Winsul,
Sinternal, Shead_insul, l_inner = size_inner_tank(fuse_tank, fuse_tank.t_insul)

if ("vacuum" in fuse_tank.material_insul) || ("Vacuum" in fuse_tank.material_insul) #If tank is double-walled
flag_vacuum = check_vacuum(fuse_tank.material_insul) #check if there is a vacuum layer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting, I wonder if insulation materials can be something that extends the Materials type in a future refactoring? E.g., something like ThermalInsulators like StructuralAlloys or something. This is fine for now though!

@askprash askprash merged commit 07b3ccc into MIT-LAE:main Jun 21, 2024
3 checks passed
@ngomezve ngomezve deleted the dev_tank branch June 24, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants