-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cryogenic fuels: hold times, more insulation options and tests #56
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 76.41% 78.09% +1.67%
==========================================
Files 69 71 +2
Lines 13169 13424 +255
==========================================
+ Hits 10063 10483 +420
+ Misses 3106 2941 -165 ☔ View full report in Codecov by Sentry. |
@@ -74,7 +75,9 @@ function tanksize!(fuse_tank, z::Float64, Mair::Float64, xftank::Float64, | |||
Winner_tot, lcyl1, tskin, Rinnertank, Vfuel, Winnertank, Wfuel_tot, Winsul_sum, t_head, Whead, Wcyl, Wstiff, Winsul, | |||
Sinternal, Shead_insul, l_inner = size_inner_tank(fuse_tank, fuse_tank.t_insul) | |||
|
|||
if ("vacuum" in fuse_tank.material_insul) || ("Vacuum" in fuse_tank.material_insul) #If tank is double-walled | |||
flag_vacuum = check_vacuum(fuse_tank.material_insul) #check if there is a vacuum layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting, I wonder if insulation materials can be something that extends the Materials
type in a future refactoring? E.g., something like ThermalInsulators
like StructuralAlloys
or something. This is fine for now though!
This PR addresses the models for aircraft with cryogenic fuels in insulated tanks: