Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved cabin layout and double decker models #67

Closed
wants to merge 13 commits into from

Conversation

ngomezve
Copy link
Contributor

@ngomezve ngomezve commented Jul 2, 2024

This PR introduces better design options if the fuselage layout has to be redesigned; for example, following a change in fuselage radius. The following changes are included:

  • The seat height is included as an input parameter to ensure that seats can fit in the cabins.
  • If the fuselage bubble has a downward shift, the floor is assumed to lie at the intersection of the two bubbles.
  • If the fuselage has two decks, the decks are no longer assumed to be symmetric or have the same number of passengers. Instead, the number of passengers in the lower deck is optimized, along with the lower deck position if the cross section is circular. This optimization is subjected to constraints on cargo bay height and cabin height.
  • A new function has been included to find the minimum radius required to have a given number of seats per row. This is useful if the radius has to be redesigned.
  • The functions to size the cabin have been moved from IO to structures.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 47.67442% with 90 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (78ba4b2) to head (4ba69ef).
Report is 154 commits behind head on main.

Files Patch % Lines
src/structures/size_cabin.jl 44.64% 62 Missing ⚠️
src/structures/update_fuse.jl 24.32% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   76.41%   77.80%   +1.38%     
==========================================
  Files          69       71       +2     
  Lines       13169    13534     +365     
==========================================
+ Hits        10063    10530     +467     
+ Misses       3106     3004     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve ngomezve marked this pull request as ready for review July 10, 2024 17:50
bug fix + better way to find min R

removed print statement
@ngomezve
Copy link
Contributor Author

This PR is now largely outdated due to the fuselage data structure revamping. I made a new PR #78 to revive the H2 models and introduce the features in this PR.

@ngomezve ngomezve closed this Aug 23, 2024
@ngomezve ngomezve deleted the dev_fuse branch September 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants