Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced Input TASOPT #77

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Reduced Input TASOPT #77

merged 3 commits into from
Sep 13, 2024

Conversation

aditeyashukla
Copy link
Contributor

  • Changed how read input works
  • First reads key in Aircraft Description: aircraft_type, then replaces the "default" model for that in case any key missing
  • If aircraft_type not specified then decides default model based on range:

Regional: range <= 2600 nmi
Narrow Body: range <= 3115 nmi
Wide Body: range <= 8500 nmi

Other changes:

  • Added error if design mission pax > maxpax
  • Added wide and regional default models to IO folder

@aditeyashukla
Copy link
Contributor Author

@askprash pls lmk if there's a different/better way to do this

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (cb36835) to head (03cb2a5).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/IO/read_input.jl 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   71.88%   73.37%   +1.48%     
==========================================
  Files          77       77              
  Lines       13684    13876     +192     
==========================================
+ Hits         9837    10181     +344     
+ Misses       3847     3695     -152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/IO/read_input.jl Outdated Show resolved Hide resolved
@askprash askprash merged commit 034578f into MIT-LAE:main Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants