Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinction between max payload and max pax #81

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ngomezve
Copy link
Contributor

@ngomezve ngomezve commented Sep 6, 2024

This PR is a revived form of PR #63. It introduces the exit_limit as a way to specify the maximum number of seats in the cabin. This is stored as a field in fuselage.cabin. In addition, the name of the input max_pax is changed to the more accurate max_payload_in_pax_equivalent.

The code now uses the exit limit to resize the fuselage where appropriate. The PR also fixes a very minor bug in the double-decker case (a parg parameter had been left behind).

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.31%. Comparing base (018c044) to head (1c5076d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/structures/size_cabin.jl 0.00% 9 Missing ⚠️
src/structures/update_fuse.jl 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   73.32%   73.31%   -0.01%     
==========================================
  Files          77       77              
  Lines       13846    13851       +5     
==========================================
+ Hits        10152    10155       +3     
- Misses       3694     3696       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants