Put stacks in their own chunks (and cleanup) #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch gives each stack its own chunk, similar to large arrays. Some advantages:
I did some quick tests and found that these changes are sometimes significant, e.g. in a stack-stress benchmark like
fib
I saw 20% improvement in space on 70 cores. Elsewhere, I don't think this change affects time or space too much.To implement this change, I disabled stack shrinking at local GCs. Perhaps this can be re-enabled in the future, but it doesn't seem outrageously important, since the threading in MPL is so well disciplined.