Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci status badge error #522

Merged
merged 5 commits into from
Oct 15, 2023
Merged

Fix ci status badge error #522

merged 5 commits into from
Oct 15, 2023

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jan 2, 2023

Hello, this PR fixes the CI status badge error on the README file and documentation page (https://uvloop.readthedocs.io/).

You can read the details here: badges/shields#8671

Before
Screenshot 2023-01-03 at 1 23 43
Screenshot 2023-01-03 at 1 37 33

After
Screenshot 2023-01-03 at 1 27 55
Screenshot 2023-01-03 at 1 37 09

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jan 2, 2023

I guess the failed tests will be fixed by #520. 🙂

EFord36 and others added 3 commits September 14, 2023 10:16
See the linked GitHub issue from the previous version of the badge:
badges/shields#8671

In summary, this type of badge was changed in a breaking fashion such that
the badges were just linking to the github issue rather than showing the
data. Updating the url resolves this.

Also update the link of the badge to specify the workflow file rather
than the name, which matches the new behaviour of the badge.
@fantix fantix merged commit 0e9ff6c into MagicStack:master Oct 15, 2023
13 checks passed
@shuuji3 shuuji3 deleted the patch-1 branch October 15, 2023 22:07
fantix added a commit that referenced this pull request Oct 22, 2023
Changes
=======

* Drop support of Python 3.7 and update CI (#578)
  (by @fantix in ee5ad26 for #578)

Fixes
=====

* Restore uvloop.new_event_loop and other missing uvloop members to typing (#573)
  (by @graingert in 5c500ee for #573)

* Fix docstring of loop.shutdown_default_executor (#535)
  (by @Gelbpunkt in 919da56 for #535)

* Fix CI status badge (#522)
  (by @shuuji3 in 0e9ff6c for #522)
@fantix fantix mentioned this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants