Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup_socket param on create_unix_server() #623

Closed
wants to merge 1 commit into from

Conversation

fantix
Copy link
Member

@fantix fantix commented Aug 28, 2024

This is derived from python/cpython#111483 but available on all Python versions with uvloop, only that it's only enabled by default for Python 3.13 and above to be consistent with CPython behavior.

Sample CI run on 3.13

This is derived from python/cpython#111483 but available on
all Python versions with uvloop, only that it's only enabled
by default for Python 3.13 and above to be consistent with
CPython behavior.
@fantix fantix requested a review from 1st1 August 28, 2024 18:09
@fantix fantix mentioned this pull request Aug 28, 2024
fantix added a commit that referenced this pull request Sep 2, 2024
This is derived from python/cpython#111483 but available on
all Python versions with uvloop, only that it's only enabled
by default for Python 3.13 and above to be consistent with
CPython behavior.

* Also add Python 3.13 to CI (#610)
* Enable CI in debug mode
* Fix CI to include [dev]

---------

Co-authored-by: Fantix King <fantix.king@gmail.com>
@fantix
Copy link
Member Author

fantix commented Sep 2, 2024

Merged in #610, @1st1 feel free to drop post-merge review comments.

@fantix fantix closed this Sep 2, 2024
@fantix fantix deleted the cleanup_socket branch September 2, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant