-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make triangulations unique to fix refimages issues. Also tweak examples used for refimages #4044
Conversation
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
Are the tests failing because the refimages aren't updated yet, or they actually just failing because I've done something wrong here? |
Looks like the reference images need an update because of this PR's changes, which makes sense. |
Have you checked that all tests look correct? Then I could upload the delaunaytriangulation related reference images. |
When I made the PR at the time everything was correct. I can double check again, I just wasn't sure if any of the other changes since had updated the refimages as I'm not sure how that's done on your end. I'll check again soon and let you know once I've confirmed. |
refimgs are partially updated for #3958 atm so some things will fail on master |
I've double checked and everything seems fine. I added another
but I don't imagine that's related. |
Yea that's a failure due to the other pr. The pr fixes a problem with how CairoMakie handles color interpolation with clipped lines. FastPixel should also be failing because of the other pr. |
Two ref images changed in point density:
This changed in terms of triangulation: And here it seems the colormapping changed, but I guess this could also be a triangulation change? The new images look consistent to me across backends and the ones I didn't mention should be the same as before. I think all of these are fine/desired changes. @DanielVandH If these still look good to you I'd be happy to merge this |
Those all look as intended to me! Thanks. |
Description
Passes
randomise=false
to all calls totriangulate
to force them to be unique.I have also tweaked the refimage test examples so that issues with randomisation or iteration order across Julia versions hopefully won't break them anymore. This hopefully fixes the issues you were having @SimonDanisch
Type of change
Checklist