Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfixes #4356

Merged
merged 4 commits into from
Sep 13, 2024
Merged

hotfixes #4356

merged 4 commits into from
Sep 13, 2024

Conversation

SimonDanisch
Copy link
Member

@MakieBot
Copy link
Collaborator

MakieBot commented Sep 13, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.53s (4.51, 4.54) 0.01+- 110.03ms (106.88, 114.17) 2.26+- 468.33ms (423.97, 492.62) 30.42+- 9.44ms (9.13, 9.67) 0.20+- 26.54ms (26.46, 26.66) 0.08+-
master 4.50s (4.48, 4.55) 0.02+- 111.65ms (107.41, 117.89) 3.37+- 566.92ms (559.30, 573.17) 4.33+- 9.09ms (8.32, 9.43) 0.39+- 26.53ms (26.39, 26.63) 0.08+-
evaluation 0.99x slower X, 0.03s (1.59d, 0.02p, 0.02std) 1.01x invariant, -1.62ms (-0.57d, 0.31p, 2.81std) 1.21x faster✅, -98.59ms (-4.54d, 0.00p, 17.38std) 0.96x invariant, 0.36ms (1.15d, 0.06p, 0.29std) 1.00x invariant, 0.01ms (0.12d, 0.83p, 0.08std)
CairoMakie 4.21s (4.18, 4.25) 0.02+- 107.41ms (105.03, 109.14) 1.38+- 169.45ms (166.73, 173.15) 2.12+- 9.75ms (9.71, 9.81) 0.04+- 1.14ms (1.13, 1.15) 0.01+-
master 4.20s (4.15, 4.25) 0.03+- 107.34ms (104.08, 109.20) 1.70+- 169.85ms (166.13, 173.28) 2.66+- 9.51ms (9.42, 9.57) 0.05+- 1.15ms (1.14, 1.18) 0.01+-
evaluation 1.00x invariant, 0.01s (0.52d, 0.35p, 0.03std) 1.00x invariant, 0.07ms (0.05d, 0.93p, 1.54std) 1.00x invariant, -0.41ms (-0.17d, 0.76p, 2.39std) 0.98x slower X, 0.24ms (4.93d, 0.00p, 0.05std) 1.01x invariant, -0.01ms (-0.66d, 0.25p, 0.01std)
WGLMakie 4.87s (4.84, 4.89) 0.02+- 111.89ms (108.94, 118.06) 2.96+- 9.79s (9.72, 9.87) 0.05+- 12.77ms (11.64, 16.76) 1.78+- 118.51ms (115.45, 120.92) 2.03+-
master 4.86s (4.82, 4.94) 0.05+- 112.61ms (109.68, 119.06) 3.19+- 9.74s (9.61, 9.90) 0.10+- 12.12ms (11.74, 12.47) 0.28+- 118.78ms (115.00, 123.21) 2.66+-
evaluation 1.00x invariant, 0.01s (0.27d, 0.62p, 0.04std) 1.01x invariant, -0.72ms (-0.23d, 0.67p, 3.07std) 0.99x invariant, 0.05s (0.67d, 0.24p, 0.08std) 0.95x noisy🤷‍♀️, 0.64ms (0.50d, 0.38p, 1.03std) 1.00x invariant, -0.27ms (-0.11d, 0.84p, 2.34std)

@SimonDanisch SimonDanisch merged commit d915a80 into master Sep 13, 2024
17 of 18 checks passed
@SimonDanisch SimonDanisch deleted the sd/hotfixes branch September 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

regression: plot recipes that take kwargs don't work anymore
2 participants