Added ManageIQ Status with conditions, versions and ingress endpoint info #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhir-kelkar
changed the title
Fryguy
changed the title
bdunne
reviewed
Jun 20, 2023
sudhir-kelkar
changed the title
bdunne
reviewed
Jul 3, 2023
|
@Fryguy Can you also take a look at this? |
|
Overall LGTM, though I admit I'm not a go person. I agree with @bdunne's comments otherwise. |
bdunne
reviewed
Jul 6, 2023
bdunne
reviewed
Jul 6, 2023
bdunne
reviewed
Jul 6, 2023
bdunne
reviewed
Jul 6, 2023
bdunne
reviewed
Jul 6, 2023
bdunne
reviewed
Jul 6, 2023
bdunne
reviewed
Jul 6, 2023
| @@ -166,6 +247,90 @@ func (r *ManageIQReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
|
|
|||
| var logger = log.Log.WithName("controller_manageiq") | |||
|
|
|||
| func FindDeployment(cr *miqv1alpha1.ManageIQ, client client.Client, name string) *appsv1.Deployment { | |||
There was a problem hiding this comment.
In a followup, do you think we should lower case these functions? I think they can be private.
|
Checked commits sudhir-kelkar/manageiq-pods@2ba13d9~...a9fa7ae with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this status implementation we are adding status conditions, ingress endpoint info and operator/operand version to the CR status.
Fixes
#https://github.ibm.com/katamari/dev-issue-tracking/issues/23259