Expand inventory #83
Merged
Expand inventory #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeboro
force-pushed
the
expand-inventory
branch
from
e2da4c0
to
54d7061
Compare
agrare
reviewed
Jul 9, 2019
app/models/manageiq/providers/redfish/inventory/parser/physical_infra_manager.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jul 9, 2019
...els/manageiq/providers/redfish/inventory/persister/definitions/physical_infra_collections.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jul 9, 2019
app/models/manageiq/providers/redfish/physical_infra_manager.rb
Outdated
Show resolved
Hide resolved
|
Overall looks good @tadeboro just a few small things |
tadeboro
force-pushed
the
expand-inventory
branch
2 times, most recently
from
158939c
to
b49dcf9
Compare
added 5 commits
July 11, 2019 10:26
Filling in those asset details makes server detail page in the UI a bit less empty.
tadeboro
force-pushed
the
expand-inventory
branch
from
b49dcf9
to
ba48b69
Compare
|
Checked commits xlab-si/manageiq-providers-redfish@123ee8f~...ba48b69 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@miq-bot remove_label wip |
agrare
approved these changes
Jul 11, 2019
|
@tadeboro thanks for doing all the refactoring to core and lenovo to get this in! We really appreciate it. |
matejart
added a commit
to xlab-si/wrapanapi
that referenced
this pull request
Jul 19, 2019
This adds `machine_type` and `product_name` properties to `RedfishServer`. Related PR: * ManageIQ/manageiq-providers-redfish#83
matejart
added a commit
to xlab-si/wrapanapi
that referenced
this pull request
Aug 28, 2019
This adds `machine_type` and `product_name` properties to `RedfishServer`. Related PR: * ManageIQ/manageiq-providers-redfish#83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits in this PR expand Redfish inventory parser and add the following functionality:
The vast majority of code changes are in the VCR recordings that we separated into a separate commit.
This PR depends on:
@miq-bot assign @agrare