Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cockpit button #1021

Merged
merged 1 commit into from
Apr 13, 2017
Merged

fix cockpit button #1021

merged 1 commit into from
Apr 13, 2017

Conversation

enoodle
Copy link

@enoodle enoodle commented Apr 12, 2017 •
edited
Loading

Using node.kubernetes_hostname instead of old and deprecated node.ipaddress

Those functions were replaced in ManageIQ/manageiq#13704. I forgot to make the change here as well.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1440204

@enoodle
Copy link
Author

enoodle commented Apr 12, 2017

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Apr 12, 2017
@enoodle
Copy link
Author

enoodle commented Apr 12, 2017

@martinpovolny PTAL

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

Checked commit enoodle@2f735d6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@martinpovolny martinpovolny merged commit 5b58a49 into ManageIQ:master Apr 13, 2017
@martinpovolny martinpovolny added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 13, 2017
simaishi pushed a commit that referenced this pull request Apr 13, 2017
@martinpovolny @simaishi
Merge pull request #1021 from enoodle/fix_cockpit_button
809f209 
fix cockpit button
(cherry picked from commit 5b58a49)

https://bugzilla.redhat.com/show_bug.cgi?id=1442179
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 809f2092da8ede7c9994762386c7137529ca61f3
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Apr 13 09:42:31 2017 +0200

    Merge pull request #1021 from enoodle/fix_cockpit_button
    
    fix cockpit button
    (cherry picked from commit 5b58a4903fd03025051bef133163b45fe7e0f5ea)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug compute/containers fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enoodle @miq-bot @simaishi @martinpovolny @dclarizio