Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legend to ad hoc chart #1124

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Add legend to ad hoc chart #1124

merged 1 commit into from
Apr 24, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Apr 24, 2017 •
edited
Loading

Description

On discussion with @Loicavenel we decided that the charts require legend.

Screenshots

Before
screenshot-localhost 3000-2017-04-24-12-24-29

After
screenshot-localhost 3000-2017-04-24-12-22-46

@yaacov
Copy link
Member Author

yaacov commented Apr 24, 2017

@miq-bot add_label compute/containers, bug

@simon3z @zeari @moolitayer @himdel please review

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commit yaacov@72fe15f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

@yaacov
Copy link
Member Author

yaacov commented Apr 24, 2017

@cben @dkorn please review

cben
cben approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moolitayer
Copy link

@yaacov what happens when we have more then two items?

dkorn
dkorn approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@dkorn dkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yaacov
Copy link
Member Author

yaacov commented Apr 24, 2017

@yaacov what happens when we have more then two items?

@moolitayer This :-)

screenshot-localhost 3000-2017-04-24-12-41-01

moolitayer
moolitayer approved these changes Apr 24, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacov Thanks
LGTM

@himdel himdel self-assigned this Apr 24, 2017
@himdel himdel merged commit 9fa2f08 into ManageIQ:master Apr 24, 2017
@himdel himdel added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@himdel
Copy link
Contributor

himdel commented Apr 24, 2017

Tested in the UI, works :)

@yaacov fine? ;)

@yaacov
Copy link
Member Author

yaacov commented Apr 24, 2017

@yaacov fine? ;)

@simon3z ?

@simon3z
Copy link
Contributor

simon3z commented Apr 26, 2017

@simon3z ?

@yaacov open a BZ and we'll consider (maybe for a z-stream releases).

@Loicavenel
Copy link

BZ open: https://bugzilla.redhat.com/show_bug.cgi?id=1445859

@yaacov
Copy link
Member Author

yaacov commented May 4, 2017 •
edited
Loading

@miq-bot add_label fine/yes

https://bugzilla.redhat.com/show_bug.cgi?id=1445859 target is 5.8.1

simaishi pushed a commit that referenced this pull request Jun 2, 2017
@himdel @simaishi
Merge pull request #1124 from yaacov/show-chart-legend
db050c7 
Add legend to ad hoc chart
(cherry picked from commit 9fa2f08)

https://bugzilla.redhat.com/show_bug.cgi?id=1458454
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit db050c705cd895c57e179c6557d2a4e6da907cbd
Author: Martin Hradil <himdel@seznam.cz>
Date:   Mon Apr 24 14:17:23 2017 +0000

    Merge pull request #1124 from yaacov/show-chart-legend
    
    Add legend to ad hoc chart
    (cherry picked from commit 9fa2f080adef5d92f336f763cd4132962ac3d88e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458454

@simaishi simaishi removed the fine/yes label Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cben cben cben approved these changes

@moolitayer moolitayer moolitayer approved these changes

@dkorn dkorn dkorn approved these changes

Assignees

@himdel himdel

Labels
bug compute/containers fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@yaacov @miq-bot @moolitayer @himdel @simon3z @Loicavenel @simaishi @cben @dkorn