Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout regression #1125

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Fix layout regression #1125

merged 1 commit into from
Apr 24, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Apr 24, 2017

Description

Sorry ... in #1121 I caused a regression.

When navigating back from the ad-hoc page back to the providers page, the layout stay without listnav.

Screenshot
Before ( When navigating back from the ad-hoc page )
screenshot-localhost 3000-2017-04-24-13-13-22

After
screenshot-localhost 3000-2017-04-24-13-11-53

@yaacov
Copy link
Member Author

yaacov commented Apr 24, 2017

@miq-bot add_label compute/containers, bug

@simon3z @cben @moolitayer @himdel please review

@himdel
Copy link
Contributor

himdel commented Apr 24, 2017

@yaacov I don't like this .. why decide based on @lastaction, when you can fix the wrong @showtype value when coming from the ad-hoc screen instead?

Seems like neither show_list nor provider details should ever have @showtype == 'ad_hoc_metrics' ;)

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commit yaacov@1f9c40e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@yaacov
Copy link
Member Author

yaacov commented Apr 24, 2017

@himdel Thanks 👍

This fixes the problem with dashboard too :-)

@himdel himdel self-assigned this Apr 24, 2017
@himdel himdel added the fine/no label Apr 24, 2017
@himdel himdel added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@himdel himdel merged commit eaf8fc3 into ManageIQ:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants