Removed unnecessary escaping from assigned server role treenodes #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a content_tag around the escaped strings, therefore, it's obsolete to call html_escape as it has its own escaping mechanism. This also fixes the escaped & in the linked BZ. https://bugzilla.redhat.com/show_bug.cgi?id=1444794
|
Checked commit skateman@5f20605 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM, makes sense :) |
simaishi
pushed a commit
that referenced
this pull request
Apr 24, 2017
Removed unnecessary escaping from assigned server role treenodes (cherry picked from commit 5a71aee)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
content_tagaround the escaped strings, therefore, it's obsolete to callhtml_escapeas it has its own escaping mechanism. This also fixes the escaped&in the linked BZ.Before:
After:
https://bugzilla.redhat.com/show_bug.cgi?id=1444794